It is my impression that Germans are one of the last groups for which it is OK to consistently portray in a negative way, generally as villains. But I’ll admit it is just an impression. What are some counter examples?
Female romantic interests for American male central characters don’t count. We all know from Star Trek that all bets are off when it comes to love interests.
The Bourne Identity.
Franka Potente’s charakter and Matt Damon’s do fall in love IIRC but she is more then only a “romantic interest” of his.
Damn. Eve beat me to it once again.
“Das Boot”? But I suppose German movies don’t count.
Marlon Brando plays a sympathetic Nazi officer in “The Young Lions” (1958).
Great movie, but I meant something more recent. It was Nazism and WWII that made Germans the generic easy-to-hate characters in American pop culture.
I’m of German descent but I’ve always been uneasy with it. Never had any interest in German culture apart from some of the composers. I blame it on viewing German culture through an American culture lens.
I hear they made a book out of it too. 
More recent? It’s a talkie, ain’t it?!
Dr. Strangelove?
OK, maybe not.
Well, Hardy Kruger was a good guy in “Hatari,” and his technical know-how was what saved everyone’s lives in “The Flight of the Phoenix.”
A more recent remake of All Quiet was made. It’s in color, and it has Ernest Borgnine playing the part of (I believe) Katzinski. I watched it in History class, and my teached mentioned that he thought this was a better movie than the origional.
Michael Caine as Colonel Steiner in The Eagle Has Landed
The Great Escape is something of a mixed bag: the Germans who run the camp are treated quite sympathetically, while the SS and Gestapo (understandably) are not.
(The attitude of the prisoners towards the camp staff was not an invention. Many of the staff were widely respected, especially the Kommandant and Hermann Glemnitz, the chief ferret [tunnel finder and general ruiner of escapes]. Glemnitz was invited to at least two reunions; on his arrival for the 1970 reunion, he is reputed to have said: “I am here to make sure that you people aren’t trying to tunnel out of Toronto.”)
Blazing Saddles.
Your teacher, with all due respect, could not be more wrong.
I’ve only seen part of this movie, and that was many years ago, but I believe A Midnight Clear has at least one sympathetic German character, an older German soldier who is tired of the war.
Terminator 2 and 3
“East of Eden”
“Schinder’s List”
Sorry for the somewhat odd hijack, but if you’re looking for something German to be proud of, try looking into their boardgames. They are pretty universally recognized as the world leaders in quality boardgames. (a niche market, but still.) Start with Settlers of Catan (Die Sielder von Catan), and work from there.
Didn’t shooting begin with the intention of making it a silent? I understood that, being all silent-talkie cuspy and junk, they began shooting for sound somewhere in the middle of the production.
All-time top, say, 25 movies for me.
The individual German soldier with a heart of gold is a movie cliche, so I un-nominate Midnight Clear. And Schindler’s list was offensively “pro-German,” so I also un-nominate that.
Raiders of the Lost Ark depicted the Nazis as cartoon buffoons, so I’d say practically any Spielberg film with Germans in it is self-loathingly sympathetic to them.
Zentropa was sympathetic to the individual German’s humanity, but it still portrays them as pretty pathetic, immediately postwar. Oh, and it’s Danish, so nevermind.
Starship Troopers is parodistically proNazi, does that count? It’s subtext is very much anti.