I have a great desk toy called “the internet.” I’m using it now!
Karl Marx piggy bank with a note that says, “like my course? Consider donating. Want to rid the university system of a tenured radical? Contribute to the retirement fund.”
I have a Magick Wish Doll I got in New Orleans years ago.
This.
Also, at the moment, one white-and-yellow cat. He thinks I’m the toy, though.
I work from home now, my office is full of desk toys collected over the years. When I worked in an office I had considerably fewer, only because we tended to reshuffle the offices pretty often and moving all that crap got to be a pain.
It’s literal. Everyone just started collecting them. I has the first three, but was soon passed by another guy in the office.
The funniest part was we hired someone new and she brought her own and immediately had more ducks than any of us
I have a diorama of tiny dinosaurs and other odd creatures (including Pokey the horse, Gumby’s companion) gathered around a Terry Francona bobblehead, threatening mayhem if he doesn’t finally pilot the Cleveland Indians to a World Series title.
government job
I have a Karl Marx rubber duck. Seriously.
No toys as such but I used to have a Buddy Christ mini statue.
From my last desk job, about 15 years ago: a binary-coded decimal clock (e.g., 13:31:03 would look like .::. : in LEDs) and a solved spherical jigsaw puzzle of The Simpsons’ season 9 cast poster.
As a computer nerd/electronic hobbyist I have various components and what not sitting around to play with. Some cell phones in various states of completeness, a Wyze camera that I’m doing horrible things to firmware-wise, a Raspberry Pi Zero, etc.
But as for toy-toys not much right now. I have a fidget spinner for some reason. For finger play I have a cheapo combination luggage lock that I sometimes pick up and “crack” by feel. Oh yeah, real secure. Some back-of-the-page-a-day-calendar mazes to glance at and solve mentally.
You know … junk.
Yo-yos. I have about a dozen spread around. Some are cheap, but most of them are fairly nice and rather expensive.
I know about three yo-yo tricks. When somebody picks up a yo-yo and tries to play with it (usually very poorly), I say, “Here. I’ll show you.” I then do my three tricks in 20 seconds and hand it back to them, refusing (just like a magician) to show them again or do any others. Most people are gob-smacked.
I have a buckyball cube and a fidget cube. I also have about eight tins of crazy Aaron’s putty. I don’t like when it gets too soft so I buy more. The staff took my anatomical rubber duck.
I also used to have a magnetic toy that was femurs and vertebrae as well as a collection of body part stress balls (heart, brain, prostate etc) Sometimes I miss the old days when the pharmaceutical reps could bring us crap without having to worry about being corrupted. Now I won’t even take a pen.
My collection of desk toys has ebbed and flowed over the years. My current employer prefers a minimum of “stuff” on our desks, so most of my yo-yos and such are home at the moment, but in the past few months I’ve acquired:
[ul]
[li]a rubber ball that lights up when it bounces (company swag)[/li][li]a Koosh[/li][li]a blue and green tangle[/li][li]a mini container of Play-Doh[/li][/ul]Those are in addition to two small fans, a desktop whiteboard, two cell phone stands, and a mini Bluetooth speaker…but they’re all gadgets/accessories more than toys, I suppose. 
I have a Cray* on my desk. 
*It’s a calculator Cray handed out at an SC conference many years ago during the launch of the X1 (so really old).