What are 'John-Johns'?

I very much doubt that. As I said, I recall them being called “john-johns” in the 1950s, long before John John Kennedy was around. Also, in the photo he’s not wearing john-johns - that is, long john style pajamas - as I knew the term.