Going off the top of my head from sources I have seen:
Are religious people happier than nonreligious people? If they have the same income, possibly. In terms of the general population, no. Living in a poor situation and religiosity are strongly linked. Probably any gain there might be comes from a sense of community. In Sweden, at least, club activities are underwritten by the government so there are (supposedly) a lot of secular clubs who are physically active and sociable. In the US, there isn’t such a thing as this so atheists and agnostics are at a disadvantage.
Are they healthier? Belief in the healing power of a deity appears likely to have some amount of placebo effect. So assuming the same level of medical care to two patients, the religious person is likely to be more healthy. But again, most religious people will probably not receive the same level of medical care as agnostics/atheists due to income differences.
Do they live longer? Probably not. I don’t imagine that the placebo effect could carry this far. --addendum, though apparently religious beliefs against suicide does help to prevent suicides. Whether that’s a good or bad thing depends on your outlook on suicide.
Are they less likely to commit crimes? Lower income and crime are highly linked. To factor in only for religion and income, my guess would be that they are roughly the same but I haven’t seen any data one way or the other.
Are they more sociable/have more friends? Answered above, somewhat.
Are they less likely to cheat on their spouse? Christians are more likely to get divorced and be unsatisfied in marriage the more religious they are (there was a recent thread about this) so probably they are more likely to cheat. This difference lessens but doesn’t disappear if you factor for income.
Are they more charitable? Inconclusive. Poorer people donate a larger percent of their income to charity. But there is no income bracket for which a higher income doesn’t donate a higher dollar amount than the lower bracket. Also, the higher an income bracket you are, the more you are paying for social services like welfare and social security. Probably many feel like if they’re going to be made to donate to charity in this fashion then they don’t have a particular need to directly contribute to charity. How religion factors into this all, who knows.
Are they more charitable once you exclude giving to their own church? No idea. See previous.
Are religious people less likely to become addicted to drugs or alcohol? These are linked to income. Otherwise, I dunno.
Do religious people recover more quickly from negative life events? Probably linked to having a social group, so probably yes but probably fixable if one followed the Swedish model.
Ultimate answer: Have a positive outlook and join a club and you’ll have any advantages religion might give you without having to subscribe to all the religious beliefs you disagree with.