It’s Every Good Boy Does Fine. This “Deserves Fudge” business is new and strange to me, and therefore unacceptable! It was probably invented by some damn millennial. 
I was taught “Every Good Boy Does Fine” and “Every Good Bird Does Fly”.
Well, the album “Every Good Boy Deserves Fudge” by Mudhoney came out in Seattle in 1991, you couldn’t get much more Gen-X like that.
The oddest one I know is “the more the yellow, the lesser he the fellow” to differentiate the Herring Gull and the Lesser black backed backed gull based on the colour of their legs. Why?
I used to have no trouble remembering PORAC** until my uncle said that the best way to remember the initials was to think of Poor Old Raggedy-Assed Cops. After that, that was all I’d remember.
** Peace Officers Research Association of California
The one I always struggle with and would never use is the one around Coral and King snakes.
Me: Red and yellow, friendly fellow. Red and black, get back jack!
Of course, this is mnemonic devices you remember. I remember, just incorrectly.
The similar (and, I think, accurate 
) one I learned in Boy Scouts as a kid:
- Red next to black, venom lack
- Red next to yellow, you’re a dead fellow
Of course, living in the upper Midwest, the odds of me running into a coral snake in the wild is effectively zero.
Yeah, I’ve never seen either in the wild around these parts so I’m not too concerned. It’s not like I would be picking up either if I were confident I had it correct. My instinct when seeing any snake is to first run, then change my shorts.
I made one up for myself to help remember the classification of organisms - Pigs Can’t Offer Free Gift Sausages…An achievement only slightly dented by the omission of Kingom
I remember a mnemonic for something to do with sandstones but is now quite lost.
Regurgitating lists in order to get through exams seems a rather silly exercise. But I guess the education system still needs cheap, arbitrary ways to select between competing students.
Good ones have a life outside the classroom.
The one I learned was:
Red and yellow kill a fellow
Red and black poison lack
And I did see one once on my patio when I lived in the country. Yet another reason why I’m glad I live in the city now. Once a scorpion fell on my head from the ceiling fan in my office.
In 1973, I took Basic Electricity and Electronics in the Navy. I still remember how to create the chart with characteristics of transistors (Base, Emitter, Collector) but for the life of me, I don’t remember what each part means. I also remember the mnemonic to determine the value of a resistor based on the color stripes, but I don’t remember all the details. Not that I’ve needed either of those devices except to pass the course.
Why is it I remember that crap but I forget why I walked into the kitchen???
I don’t know the mnemonic, but I just remember as black, brown, colors of the rainbow in order (no indigo because, hey, screw indigo), grey, white. It just sort of makes sense to me as a logical way to put them in order. The main thing to remember is it starts on black and brown and ends on grey and white, which, to me, feels logical.
Sinclair Lewis in Arrowsmith has this “On Old Olympus’ topmost top, a fat-eared German viewed a hop” as a mnemonic for the nervous system. Not sure why it’s changed from what you have.
Silly Old Hitler
Caught Awful Headaches
Through Our Airmen
One of my high school friends invented a mnemonic for the same purpose (sine, cosine, and tangent calculations), and which is still lodged in my brain, despite not having to use it since 1983:
Some Old Hens
Cackle And Howl
Til Old Age
The resistor colors code mnemonic I learned was “Better Be Right Or Your Great Big Venture Goes West. Get Started Now.” For Black (0), Brown (1), Red (2), Orange (3), Yellow (4), Green (5), Blue (6), Violet (7), Gray (8), and White (9) for the values and exponent, and Gold (5%), Silver (10%), and None (20%) tolerance bands. Although in the decades since I learned this, the fourth (tolerance) band now can use the same color code as the value bands.
There’s a really terrible mnemonic that was slightly cleaned up with the substituted word “race”. I would recommend the above one you can share without offense.
“Big Buicks Run On Yellow Gas But Volkswagens Go Without” Is the one that we were officially supposed to use. But the terrible one is much easier to remember.
The terrible one has the advantage of helping you remember that “bAd” and “bOys” go with “blAck” and “brOwn”.
Really. I learned “King Philip Came Out From Going Swimming.”
SOHCAHTOA
Something about Sine, Cosine and Tangent, and Opposite, Hypotenuse and Adjacent.
I remember Sohcahtoa, and it was very useful in math sometime back in 1982 or so.
Today I have no clue what that was all about.
Well, you’ve remembered what all the letters stand for, so it’s, in a right triangle, the sine of an angle is the ratio of the (length of the) opposite side to the hypotenuse (SOH), cosine is adjacent side to the hypotenuse (CAH), and tangent is opposite side over adjacent side (TOA).