Being qualified and reasonably knowledgable in economics, I’ll simply say that the opinions expressed thus far pretty much nail it flat.
The “New Deal” was not a cohesive set of interrelated programs; it was a lot of very different programs that were being tried to fix the economy. Objectively, I cannot honestly say that many of them were terribly successful. Some did have their virtues, like the WPA or the TVA project, and there ARE good things about Social Security. We could spend a 150-post thread talking about any one of the programs and not reach a solid conclusion about its success, but having lookd at the issue, I think I’ll just say that some programs had their successes, some were total failures, and overall the effect was not much, financially speaking.
The truth is that much of it was a case of constructing barn doors after all the horses had gotten out; the reforms that would have worked best were the reforms that would have PREVENTED the Depression, and those had to take place before Roosevelt was President. Actually, even that was too late. The time to stop the Depression was in August 1914; World War I put into motion a series of events that pretty much sank the world economy. World War I was probably the worst thing to ever happen to the human race; I would say, without exaggerration IMHO, that it set our species back 50-100 years, easy.
By the time Roosevelt was elected the U.S. had been effectively hit by a freight train of history that it probably could not have entirely avoided. Financial and economic reforms pre-1929 could have softened the blow to be sure, but bad times were coming no matter what, and by Roosevelt’s presidency all he could do was shuffle the deck chairs.
And to that I must enthusiastically endorse Polycarp and jklann’s point. Roosevelt’s strength wasn’t any particular policy, it was his strategic leadership. It is hard to believe this now, but the Depression could have destroyed the United States of America, just the way it destroyed Germany. The rebellion was simmering. People were desperate and could quite easily have been led astray. Instead, Roosevelt led the USA precisely the way it should have been led; with a reasonable degree of care while saying “We are trying to fix this, we’re doing SOMETHING, please work with us.”
We had an argument about Nelson Mandela a few months ago in which the same case-against was made; the guy’s policies were all bullshit so why do people like him? The counterargument, which I wholly endorse, was… it’s not what he did, it’s what he AVOIDED. Mandela actively prevented South Africa from turning into a horrid bloodbath of vengeance. Roosevelt, IMHO, helped prevent chaos and violence and maybe open rebellion. Granted, it was never AS likely as South Africa going belly up, but it was there. You can make this same point about a lot of leaders - Winston Churchill, for instance. Churchill’s specific strategic military ideas were mostly idiotic; his grace was that his leadership and dedication kept the UK fighting and resisting. That’s Roosevelt; he kept the USA fighting the Depression, rather than devolving into something a lot worse.