Over at my board, Fenris figured out how to make automatically nested quotes (where if you quote a post that itself contains a quote, the quote isn’t removed) – it turns out it’s ridiculously easy. This used to be the default behavior, but was changed in a later vBulletin version.
It came up last year in this thread, but at the time it appeared the only solution was to install a hack, which TPTB were understandably loathe to do, but this is so simple that I thought I’d post it and see if someone with admin rights and three spare minutes might go ahead and implement it.
Here’s how you do it:
Log onto the server
Edit the file includes/functions.php (e.g. using nano)
In the function strip_quotes (starts on line 1693, or search for strip_quotes), make the following line the first line of the function:
return $text;
Save the file. That’s it.
So, to be completely clear, the function will change from:
function strip_quotes($text)
{
$lowertext = strtolower($text);
to
function strip_quotes($text)
{
return $text;
$lowertext = strtolower($text);
(Since nothing after the return is going to get called, you could of course delete the rest of the function code, but you may as well leave it there in case you decide to restore things back the way they were.)
I like the nested quote functionality enough that I figured I’d share – feel free to disregard if you prefer it the way it is, of course.
And here I’ve been cut&pasting to do that! Joseph Smith, I’ve been wasting a lot of time, if it can be done that easily! I will vote for that idea, the instant this board becomes a democracy!
I dunno. There still are a lot of people who just push the quote button and don’t edit to the relevant part. This would make that problem worse. An ongoing conversation would wind up repeating everything that had ever been said before.\
I actually am on a board that has removed (well, never implemented) the quote button to avoid this stuff.
If laziness is a complaint, there are far more people who don’t go through the hassle of multi-quoting, resulting in confusing posts. It can be a particular pain in the ass to quote posts that have non-board quotes. That is, if a person quotes a snippet or three from an article with commentary, rebuilding a coherent quote of that poster means a lot of copy and pasting.
I think he means the difference between installing a hack and adding a single line of code. While both are hacks, the former would require someone with a lot of knowledge and probably a lot of time to review the hack’s code to look out for malicious or buggy code. In the suggested case, while it’s technically a hack, the primary reasons to be wary don’t apply.
ETA: Of course, that doesn’t mean that TPTB won’t still balk at making any changes to the code no matter how minor seeming. And the above refers to what I think Giraffe was thinking, not what I think the admin’s rationale is.
I can’t think of a reason NOT to have nested quotes as the default. Even if you can give one, it’s easier to remove some lines than do some careful copy&paste magic to add them.
Sure, there are simple cases (yet as MOL said, just hitting “quote” is even easier).
But say it’s post 57, and the poster is quoting posts 12, 17, and 42. Absolutely not unusual. That means searching through the thread to find those internal quotes, then multiquoting, then rearranging. The rearranging you did was straightforward; if this hypothetical poster is commenting between lines it can get fairly obnoxious.
Heck, just look at your post and consider the two you quoted being 15 to 20 posts apart. Replying to you and leaving out the nested quotes is (IMHO) rude, if the nested quotes are relevant. It’s similar to being too lazy to post a link in the OP of a Pit thread or similar.
Or consider how many people post quotes of non-board material. Discussions of a court cases and news stories are routine. There is no multi-quote button for that. Sure, it could be a nice, simple, tidy case of one poster quoting one block of text, but it’s often much more complicated than that.
The elegant nested quote feature eliminates the entire mishagosh with no loss of board integrity, and because it makes quoting easier, actually adds to overall clarity.
Other than “I won’t use them,” is there any reason (from a member’s perspective) to argue against their restoration?
Sorry, sloppy language on my part. I meant it wasn’t a hack like the usual vBulletin hacks – vbulletin.org is filled with software add-ons you can install to modify the behavior of the boards, most of which aren’t supported and could possibly have unintended side effects. Because the installation of these is a bit more opaque, I think TPTB have tended to avoid them entirely to prevent possible problems down the road.
This is still a hack in the strict sense of the word, but because it’s so simple, it’s not likely to affect future upgrades (and could be trivially reversed if it did).
Again, TPTB may prefer to keep things the way they are, which is fine – I just wanted to make them aware of the option if they’re interested.
Yeah, sure, a blanket don’t meddle with things you don’t understand policy can make sense. But that’s why I added the “from a member’s perspective” bit.
To me, this doesn’t look so much like a hack, as a removal of a hack. Basically, for some reason they deliberately wrote a function that removes the nested quotes (why?), and this is just disabling that function.
Nope. But considering how much of a hassle your hypothetical was (and that’s probably a heck of a lot more common than my side-by-side quotes), I wouldn’t say that not going through those hoops is “rude”. You can always preface your quote with “You responded to [Poster]'s comment about [subject] with:” It’s certainly not easier than automated nested quotes, but it’s easier than manually doing it.
