The sensationalist title is misfortunate, since they are drinking reclaimed water, not “urine”. It’s always been a given that any long-term human habitation in space is going to require recycling, and water is the most obvious place to start.
Both Apollo and the Shuttle used hydrogen fuel cells for electricity, with drinkable water as the byproduct. In fact up until now the Shuttle was generating a surplus of water which was delivered to the ISS. Skylab, IIRC, simply had a reserve of water big enough for the planned lifetime of the station. The Russians I don’t know about, but their Mir program featured regular automated cargo deliveries so maybe they just shipped more drinking water as needed.
Donovan sang about this back in 1973 on his Cosmic Wheels album:
You may well ask now what becomes
Of liquid they consume
A pipe is led from penis head
To a unit in the room
The water is recirculated
Filtered for re-use
In case some anti-gravity-
Pee gets on the loose.