Before, easily. That was a popular movie, and filled with quotable quotes.
Among others. . .
“I can eat fifty eggs.”
“Sometimes nothing is the coolest hand.”
Something about rules in a knife fight. (or was that butch cassidy.)
Anyway, “what we have here is failure to communicate.” (or wrongly, “a failure to communicate”) was a widely quoted line before the GnR song, and people knew what it was from, as opposed to “we don’t need no stinking badges.”
It helps that “what we have here is failure to communicate” is applicable to lots of situations.
That tends to support the contention that the phrase used in the film by Strother Martin (wonderful character actor seen in other films such as the Wild Bunch and True Grit) preceeded the song.
It was Butch Cassidy and the Sundance Kid said by Paul Newman just before kicking Ted Cassidy in the nads (Cassidy is better known as Lurch from the TV series The Adams Family).
Not the question, reread the OP. The question was when was the quote made famous.
The answer is of course what you said however. The phrase was already famous and often heard before Guns-n-Roses.
Strother Martin was guest host of an early episode of Saturday Night Life (19 April 1980 according to IMDb, not long before his death). In one sketch, Bill Murray was at a French language summer camp and it was a direct parody of Cool Hand Luke. “All berets must be worn at a slant. Anyone not wearing his beret at a slant spends a night in le box.” Murray runs away at one point and is brought back by two guards. Martin tries to get Murray to speak French by showing him a picture of a small cat. “Le chat et petit! What we’ve got here is failure to communicate bilingually!”
Actually, it’s not exactly wrong. The phrase is first said by Captain early in the film, sans the “a”. However, Luke mocks Captain with the line while trapped in the church near the end and includes the “a”.
The phrase was promoted as part of the trailer for the film (click on the film reel), which made it a catchphrase even before the film came out. People started picking up on it even if they haven’t seen the movie.
To be precise, according to the trailer, it’s “What we’ve got here is failure to communicate.”
I had an English teacher in high school who, when someone answered a question incorrectly, would shout, “What we have here is a failure to communicate!” To which the class would shout back, in unison, “My mind’s right, boss!”