I’ve spent material numbers of days in both Montreal & Vancouver, so that scores me Quebec & British Columbia. I’ve overnighted in Toronto, but not 24 hours worth. That’s it for our fine Northern friends.
I’ve resided long-term (>1 year) in 6 US states (CA, AZ, OK, NV, MO, FL) and been temporarily stationed (> 1 month) in 4 more (WA, NM, NY, TX). I’ve vacationed or worked multiple consecutive days in 21 more states (IL, SC, WI, OR, UT, CO, KS, NJ, GA, TN, MA, AK, HI, CT, LA, MN, MI (lower), KY, MD, ME, & OH) that I can recall. Plus the district of DC & the territory of PR.
I’ve stayed >24 consecutive hours in probably ~8 more, but no practical way to recall or research which. There gets to be a lot of overlap wherein I’ve had long layovers in states where I’ve also vacationed or lived.
So definitely 31 US states, definitely two US non-state entities, and probably over 40 total.
Which is a decent haul for having made no particular attempt to check all the boxes and for having spent a couple decades not vacationing at all.